Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize useGlobalStylesOutput and LivePreview usage #235

Merged
merged 4 commits into from
May 17, 2023
Merged

Optimize useGlobalStylesOutput and LivePreview usage #235

merged 4 commits into from
May 17, 2023

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented May 8, 2023 •
edited
Loading

  1. Optimizes unnecessary calls to useGlobalStylesOutput.
  2. Optimizes step live previews by preventing heavier re-renders.
  3. Memoize parts of the ScaledBlockPreview component by taking reference from Gutenberg.

Edit: It seems like I created this one from the fix/js-translations branch so I am adding that branch as the base for easier code review.

@arunshenoy99 arunshenoy99 added the WIP PR is a Work in Progress and not ready for review. label May 8, 2023
@arunshenoy99 arunshenoy99 changed the title Enhance/optimize use global styles output usage Optimize useGlobalStylesOutput and LivePreview usage May 8, 2023
@arunshenoy99 arunshenoy99 added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels May 9, 2023
@arunshenoy99 arunshenoy99 changed the base branch from trunk to fix/js-translations May 9, 2023 09:11
Base automatically changed from fix/js-translations to trunk May 10, 2023 06:48
@arunshenoy99
Merge branch 'trunk' of https://github.com/newfold-labs/wp-module-onb…
73a78af 
…oarding into enhance/optimize-use-global-styles
@arunshenoy99
remove unnecessary check in site pages, add extra check before scroll…
c091354 
…ing into view, prevent header menu API call when same selection made
officiallygod
officiallygod approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@officiallygod officiallygod added QA This PR is in QA and removed Code Review The PR is in Code Review labels May 13, 2023
@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels May 17, 2023
@arunshenoy99 arunshenoy99 merged commit f55ce88 into trunk May 17, 2023
@arunshenoy99 arunshenoy99 deleted the enhance/optimize-use-global-styles branch May 17, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @officiallygod